[PATCH v1] usb: kbd: destroy device after console is stopped

[Andy Shevchenko]

On Thu, Jan 28, 2021 at 01:24:04PM -0500, Tom Rini wrote:
> On Thu, Jan 28, 2021 at 08:18:47PM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote:
> > > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote:
> > > > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote:
> > > > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote:

...

> > > > > Unfortunately I have unrelated bug somewhere:
> > > > > Traceback (most recent call last):
> > > > >   File "/home/andy/prj/u-boot/./test/py/test.py", line 20, in <module>
> > > > >     sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args))
> > > > > TypeError: console_main() takes 0 positional arguments but 1 was given
> > > > 
> > > > Seems test cases are broken in U-Boot.
> > > > I'm not sure how you were able to run them.
> > > 
> > > This is I guess what Heinrich was posting a patch for earlier today.
> > > The supported way to run the tests (so that they're the same for
> > > everyone) is to use "pip" and "pip install -r test/py/requirements.txt".
> > 
> > My Gosh! It is full of package == version, which is simply awful. Can it be
> > more flexible?
> > 
> > I hate this Python hell.
> 
> It's intentional to follow the best practices of using python packages
> as best I can tell.  CI doesn't mean so much if it's not repeatable and
> non-versioned packages mean that you can't be sure that running a test 6
> months from now gives you what you get today on the same code base.

I agree on CI point, I disagree on end user's point of view.
I have a distribution that has provided all required packages. Moreover, I have
another (locally installed) packages that may require something else. The Py
virtual environment maybe a way to solve this, but it's like an exploitation of
the hi-tech laboratory to chop a firewood.

And as I told, it's not your fault, it's "best practices of using Py packages".

-- 
With Best Regards,
Andy Shevchenko