[PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

Amit Tomar atomar25opensource at gmail.com
Mon Mar 1 14:17:26 CET 2021


Hi,


> So this whole mode handling here looks dodgy. Below you mix "assignments
> to mode" with "ORing in values", without actually ever initialising mode
> explicitly. I wonder why the compiler doesn't warn about this, I can see
> paths were you OR into an uninitialised value.
>
> But the compiler already has initialized mode to 0, that is why there is
no warning.
In order to test , printed out mode value which suggests this variable is
initialized.

Thanks
-Amit


More information about the U-Boot mailing list