[PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

[Maxime Ripard]

On Tue, Mar 02, 2021 at 05:14:44PM +0100, Köry Maincent wrote:
> Hello Maxime,
> 
> Thanks for your review.
> 
> On Tue, 2 Mar 2021 17:05:38 +0100
> Maxime Ripard <maxime at cerno.tech> wrote:
>  
> > The split of that patch and the previous one is weird: you're adding a
> > Kconfig symbol doing close to nothing in patch 9, and you add the logic
> > behind it here
> > 
> > It would be more natural to have the Kconfig option and the code here,
> > and 
> 
> Ok I will merge them into one commit.

Sorry my sentence was incomplete, I meant to say

and enable the Kconfig symbol in another patch

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210302/2562aa7f/attachment.sig>