[PATCH v4 05/16] gpio: Drop dm_gpio_set_dir()

[Tom Rini]

On Thu, Mar 04, 2021 at 09:22:35AM -0500, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 3 Mar 2021 at 15:39, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Thu, Feb 04, 2021 at 09:21:58PM -0700, Simon Glass wrote:
> >
> > > This function is not used. Drop it.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > >
> > > Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> >
> > I'm dropping this patch as it seems to be an explicit break of:
> > commit 6befb51f349459c96ed64412070feda7472cf152
> > Author: Harm Berntsen <harm.berntsen at nedap.com>
> > Date:   Sun Nov 29 09:47:15 2020 +0000
> >
> >     i2c: i2c-gpio: Fix GPIO output
> >
> >     The dm_gpio_set_dir_flags function cannot be used to update the
> >     configuration of a GPIO pin because it does a bitwise OR with the
> >     existing flags. Looks like commit 788ea834124b ("gpio: add function
> >     _dm_gpio_set_dir_flags") has introduced this behaviour and the i2c-gpio
> >     driver has been broken since.
> >
> >     Signed-off-by: Harm Berntsen <harm.berntsen at nedap.com>
> >     CC: Heiko Schocher <hs at denx.de>
> >     CC: Patrick Delaunay <patrick.delaunay at st.com>
> 
> Yes I noticed that but only recently, somehow. I have a patch to adjust it.
> 
> Does this mean you are planning to apply the rest of the series? If so
> I'll see how things land and send a patch after that.

Yes, I have the rest of the series about to go in to -next.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210304/9d3e8396/attachment.sig>