[PATCH V4 00/13] net: smc911x: Convert to DM

[Adam Ford]

On Thu, Mar 4, 2021 at 9:15 AM Adam Ford <aford173 at gmail.com> wrote:
>
> On Thu, Mar 4, 2021 at 9:11 AM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Thu, Mar 04, 2021 at 08:41:23AM -0600, Adam Ford wrote:
> > > On Tue, Apr 28, 2020 at 8:04 AM Marek Vasut <marek.vasut at gmail.com> wrote:
> > > >
> > > > On 4/28/20 2:45 PM, Adam Ford wrote:
> > > > > On Wed, Mar 25, 2020 at 11:47 AM Marek Vasut <marek.vasut at gmail.com> wrote:
> > > > >>
> > > > >> Perform DM conversion of the SMC911x driver.
> > > > >>
> > > > >> Note that the DT compatible is set only for 9115 , so this might need
> > > > >> to be changed.
> > > > >>
> > > > >> Marek Vasut (13):
> > > > >>   net: smc911x: Remove pkt_data_{push,pull}
> > > > >>   net: smc911x: Replace malloc()+memset() with calloc()
> > > > >>   net: smc911x: Rename smc911x_rx() to smc911x_recv()
> > > > >>   net: smc911x: Invert the logic in smc911x_miiphy_{read,write}()
> > > > >>   net: smc911x: Fix potential memleak() in init fail path
> > > > >>   net: smc911x: Pull MII registration into separate function
> > > > >>   net: smc911x: Inline all functions from header file
> > > > >>   net: smc911x: Drop weak alias from 32bit accessors
> > > > >>   net: smc911x: Convert IO accessors to {read,write}{w,l}()
> > > > >>   net: smc911x: Pass around driver private data
> > > > >>   net: smc911x: Clean up the status handling in smc911x_recv()
> > > > >>   net: smc911x: Split non-DM specific bits from common code
> > > > >>   net: smc911x: Add DM support
> > > > >>
> > > > >>  drivers/net/Kconfig                  |   2 +
> > > > >>  drivers/net/smc911x.c                | 559 +++++++++++++++++++++------
> > > > >>  drivers/net/smc911x.h                | 157 --------
> > > > >>  examples/standalone/Makefile         |   5 +-
> > > > >>  examples/standalone/smc911x_eeprom.c | 150 +++++++
> > > > >>  5 files changed, 602 insertions(+), 271 deletions(-)
> > > > >>
> > > > >> Cc: Joe Hershberger <joe.hershberger at ni.com>
> > > > >> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> > > > >>
> > > > >
> > > > > Just wondering when we can expect these to get merged?   I have a
> > > > > patch pending this so I can make a build warning go away about meeting
> > > > > requirements for 2020.07, but without this patch, it causes build
> > > > > errors.
> > > >
> > > > I am tempted to just pick all the network patches via u-boot-sh, since I
> > > > have like 40 outstanding patches for various ethernet drivers myself and
> > > > I didn't hear from Joe for about a month now.
> > >
> > > Ping?  It's been nearly a year, and I wrongly assumed this had been accepted.
> > >
> > > I noticed this is still in limbo and my board is throwing a warning
> > > because DM_ETH is not enabled and it's at rish of being removed.  I
> > > have an additional patch to prevent that, but until this patch is
> > > accepted, mine will not build.
> >
> > This is merged:
> > commit 8148693b988fb36463dbc12cef4b7947acae9846
> > Author:     Marek Vasut <marek.vasut+renesas at gmail.com>
> > AuthorDate: Sun Mar 15 17:39:01 2020 +0100
> > Commit:     marex <marex at desktop.lan>
> > CommitDate: Fri May 1 15:37:48 2020 +0200
> >
>
> Cool.  Sorry for the noise.  For some reason that driver doesn't
> appear to build with DM_ETH enabled.  I'll investigate further
>

Sorry for the noise.  I was on 2020.04 rc branch and not 2021.04

That was my mistake. (I am embarrassed)

> adam
>
> >     net: smc911x: Add DM support
> >
> >     Add support for U-Boot DM and DT probing. Furthermore, build the
> >     SMC911x standalone EEPROM example only for the non-DM case, as it
> >     is not converted yet.
> >
> >     Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
> >     Cc: Joe Hershberger <joe.hershberger at ni.com>
> >     Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> >
> > --
> > Tom