[PATCH 5/5] test: Add gpio-sysinfo test

Simon Glass sjg at chromium.org
Fri Mar 5 05:08:35 CET 2021


On Mon, 1 Mar 2021 at 15:46, Sean Anderson <sean.anderson at seco.com> wrote:
>
> This adds a test for the gpio-sysinfo driver.
>
> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
> ---
>
>  arch/sandbox/dts/test.dts |  7 ++++
>  test/dm/Makefile          |  1 +
>  test/dm/sysinfo-gpio.c    | 69 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 77 insertions(+)
>  create mode 100644 test/dm/sysinfo-gpio.c
>

Reviewed-by: Simon Glass <sjg at chromium.org>

nit below

> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> index e95f4631bf..6137061d7a 100644
> --- a/arch/sandbox/dts/test.dts
> +++ b/arch/sandbox/dts/test.dts
> @@ -1340,6 +1340,13 @@
>                 compatible = "sandbox,sysinfo-sandbox";
>         };
>
> +       sysinfo-gpio {
> +               compatible = "gpio-sysinfo";
> +               gpios = <&gpio_a 15>, <&gpio_a 16>, <&gpio_a 17>;
> +               revisions = <19>, <5>;
> +               names = "rev_a", "foo";
> +       };
> +
>         some_regmapped-bus {
>                 #address-cells = <0x1>;
>                 #size-cells = <0x1>;
> diff --git a/test/dm/Makefile b/test/dm/Makefile
> index e70e50f402..2ba81ee76b 100644
> --- a/test/dm/Makefile
> +++ b/test/dm/Makefile
> @@ -93,5 +93,6 @@ obj-$(CONFIG_SCMI_FIRMWARE) += scmi.o
>  ifneq ($(CONFIG_PINMUX),)
>  obj-$(CONFIG_PINCONF) += pinmux.o
>  endif
> +obj-$(CONFIG_SYSINFO_GPIO) += sysinfo-gpio.o
>  endif
>  endif # !SPL
> diff --git a/test/dm/sysinfo-gpio.c b/test/dm/sysinfo-gpio.c
> new file mode 100644
> index 0000000000..a700352ff8
> --- /dev/null
> +++ b/test/dm/sysinfo-gpio.c
> @@ -0,0 +1,69 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2021 Sean Anderson <sean.anderson at seco.com>
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <log.h>
> +#include <dm/test.h>

put at end

> +#include <sysinfo.h>
> +#include <test/test.h>

then this after dm/test.h


> +#include <test/ut.h>
> +#include <asm/gpio.h>
> +


More information about the U-Boot mailing list