[PATCH] rk3399: Add basic support for helios64
dgilmore at fedoraproject.org
Fri Mar 5 19:08:32 CET 2021
Not all of the new files have SPDX headers as well. There was a second
submission of this patch set this week. Perhaps you can work with
Christian on the support?
On Sat, Feb 27, 2021 at 9:32 PM Dennis Gilmore
<dgilmore at fedoraproject.org> wrote:
> On Fri, Feb 26, 2021 at 12:57 AM Uwe Kleine-König <uwe at kleine-koenig.org> wrote:
> > Hi Dennis,
> > thanks for your feedback.
> > On 2/26/21 12:23 AM, Dennis Gilmore wrote:
> > > Thanks for submitting, I have been meaning to do so myself, I have
> > > been meaning to go through and try get the dts files in a decent
> > > shape. I think that most of what is in
> > > arch/arm/dts/rk3399-kobol-helios64-u-boot.dtsi belongs in
> > > arch/arm/dts/rk3399-kobol-helios64.dts
> > I understood that the intention of the separation into two files is that
> > the one should track the Linux dts. Is that wrong?
> That is not wrong, however the only things that should be in the
> -u-boot.dtsi files are the things that are u-boot specific and needed
> to make u-boot work. everything else should go into Linux also
> > > I also wonder if we shouldn't
> > > default to building an image for use in the SPI flash since the system
> > > has it available.
> > I didn't test that but expected that I can write the resulting image to
> > the spi flash and it works just fine. If you want something else here I
> > need some direction about what to change.
> at the least the env should be in spi. there may be some things I am missing
> > Best regards
> > Uwe
More information about the U-Boot