[PATCH u-boot 07/39] compiler.h: align the __ADDRESSABLE macro with Linux' version

Marek Behun marek.behun at nic.cz
Mon Mar 8 12:04:56 CET 2021


On Mon, 8 Mar 2021 18:29:29 +0800
Bin Meng <bmeng.cn at gmail.com> wrote:

> On Mon, Mar 8, 2021 at 5:23 PM Marek Behun <marek.behun at nic.cz> wrote:
> >
> > On Mon, 8 Mar 2021 15:27:41 +0800
> > Bin Meng <bmeng.cn at gmail.com> wrote:
> >  
> > > >  #define __ADDRESSABLE(sym) \
> > > >         static void * __section(".discard.addressable") __used \
> > > > -               __PASTE(__addressable_##sym, __LINE__) = (void *)&sym;
> > > > +               __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)&sym;  
> > >
> > > nits: need one space after ,  
> >
> > This is copy-paster from Linux, so it should be first fixed there.  
> 
> Do you mean this whole file is copy-paster from Linux? Is this the
> only place that U-Boot's version is different? If not, probably we
> need to do a sync with the Linux one.

Currently it is different from Linux's version, but yes, this and other
files are periodically synced with Linux' version.

I am not going to do a whole sync of all these headers in this series,
though.

Marek


More information about the U-Boot mailing list