[PATCH u-boot 11/39] binman: declare symbols externally visible

[Marek Behun]

On Mon, 8 Mar 2021 18:31:26 +0800
Bin Meng <bmeng.cn at gmail.com> wrote:

> On Mon, Mar 8, 2021 at 5:26 PM Marek Behun <marek.behun at nic.cz> wrote:
> >
> > On Mon, 8 Mar 2021 15:47:38 +0800
> > Bin Meng <bmeng.cn at gmail.com> wrote:
> >  
> > > Hi Marek,
> > >
> > > On Sun, Mar 7, 2021 at 12:59 PM Marek Behun <marek.behun at nic.cz> wrote:  
> > > >
> > > > I forgot to drop this patch. It is not needed, please ignore it.
> > > >  
> > >
> > > Why is this not needed anymore?  
> >
> > It was not needed at all, binman does not fail when its symbols are not
> > explicitly declared to be visible.  
> 
> Then why was it needed in the previous patch? Or is this due to
> undeterminism of LTO?

It wasn't needed. I did not test binman then, I just grepped for all
occurances of __attribute__, found occurances where it looked like it
would break LTO and applied, just to be sure.