[PATCH v5 1/2] gpio: i2c-gpio: Drop use of dm_gpio_set_dir()
Harm Berntsen
harm.berntsen at nedap.com
Mon Mar 8 15:35:04 CET 2021
I've just tested this on top of the current master (90964ab5) and this
breaks my board (Kirkwood CPU with MVEBU_GPIO=y and DM_I2C_GPIO=y).
I'll do some debugging to see what goes wrong.
-----Original Message-----
From: Tom Rini <trini at konsulko.com>
To: Heiko Schocher <hs at denx.de>, Harm Berntsen
<harm.berntsen at nedap.com>
Cc: Simon Glass <sjg at chromium.org>, U-Boot Mailing List
<u-boot at lists.denx.de>, Patrick Delaunay <patrick.delaunay at st.com>
Subject: Re: [PATCH v5 1/2] gpio: i2c-gpio: Drop use of
dm_gpio_set_dir()
Date: Mon, 08 Mar 2021 08:16:53 -0500
On Mon, Mar 08, 2021 at 05:59:45AM +0100, Heiko Schocher wrote:
> Hello Simon,
>
> On 08.03.21 04:45, Simon Glass wrote:
> > This is the only driver that uses this function. Update it to use
> > the
> > alternative which is dm_gpio_set_dir_flags().
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> > drivers/i2c/i2c-gpio.c | 19 +++++++++----------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
>
> Reviewed-by: Heiko Schocher <hs at denx.de>
The series is at:
https://patchwork.ozlabs.org/project/uboot/list/?series=232639&state=*
and I'd really like to see a tested-by. Harm, are you able to test
this
still since you had to fix this area before? Thanks!
More information about the U-Boot
mailing list