[PATCH v2 4/4] arm: mvebu: Espressobin: Enable watchdog support but do not start it

[Stefan Roese]

On 09.03.21 14:26, Pali Rohár wrote:
> Espressobin had disabled watchdog support (CONFIG_WDT) because older stable
> Linux kernel versions (which are used by current stable OpenWRT and Debian
> versions) do not have support for Armada 3700 watchdog driver. Therefore
> they are not able to periodically kick watchdog so Espressobin enter into
> boot loop.
> 
> This change enable CONFIG_WDT, CONFIG_WDT_ARMADA_37XX and CONFIG_CMD_WDT
> options which add support for U-Boot 'wdt' command. And unset new
> CONFIG_WATCHDOG_AUTOSTART option which cause that watchdog is not
> automatically started by U-Boot during init phase, like when CONFIG_WDT
> option is not set at all.
> 
> So with this change, U-Boot on Espressobin would have working 'wdt' command
> which can be used from boot scripts (e.g. for enabling watchdog prior new
> Linux booting kernel). But default behavior of watchdog status stays
> unchanged, U-Boot does not start watchdog on Espressobin during its init
> phase.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   configs/mvebu_espressobin-88f3720_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> index c791f98dfea5..20aa21b06b3d 100644
> --- a/configs/mvebu_espressobin-88f3720_defconfig
> +++ b/configs/mvebu_espressobin-88f3720_defconfig
> @@ -32,6 +32,7 @@ CONFIG_CMD_MMC=y
>   CONFIG_CMD_PCI=y
>   CONFIG_CMD_SPI=y
>   CONFIG_CMD_USB=y
> +CONFIG_CMD_WDT=y
>   CONFIG_CMD_TFTPPUT=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y
> @@ -88,5 +89,8 @@ CONFIG_USB_ETHER_ASIX=y
>   CONFIG_USB_ETHER_MCS7830=y
>   CONFIG_USB_ETHER_RTL8152=y
>   CONFIG_USB_ETHER_SMSC95XX=y
> +# CONFIG_WATCHDOG_AUTOSTART is not set
> +CONFIG_WDT=y
> +CONFIG_WDT_ARMADA_37XX=y
>   CONFIG_SHA1=y
>   CONFIG_SHA256=y
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de