[PATCH] tee: optee: Change printing during optee_probe

Ilias Apalodimas ilias.apalodimas at linaro.org
Wed Mar 10 12:01:00 CET 2021

Right now the error messages when optee has a version mismatch or shared
memory is not configured are done with a debug().
That's not very convenient since you have to enable debugging to figure
out what's going on, although this is an actual error.

So let's switch the debug() -> log_err() and report those explicitly.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
 drivers/tee/optee/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index b898c32edc0b..1b0a7c0c9668 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -624,14 +624,14 @@ static int optee_probe(struct udevice *dev)
 	u32 sec_caps;
 	if (!is_optee_api(pdata->invoke_fn)) {
-		debug("%s: OP-TEE api uid mismatch\n", __func__);
+		log_err("%s: OP-TEE api uid mismatch\n", __func__);
 		return -ENOENT;
 	print_os_revision(dev, pdata->invoke_fn);
 	if (!api_revision_is_compatible(pdata->invoke_fn)) {
-		debug("%s: OP-TEE api revision mismatch\n", __func__);
+		log_err("%s: OP-TEE api revision mismatch\n", __func__);
 		return -ENOENT;
@@ -642,7 +642,7 @@ static int optee_probe(struct udevice *dev)
 	if (!exchange_capabilities(pdata->invoke_fn, &sec_caps) ||
 	    !(sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)) {
-		debug("%s: OP-TEE capabilities mismatch\n", __func__);
+		log_err("%s: OP-TEE capabilities mismatch\n", __func__);
 		return -ENOENT;

More information about the U-Boot mailing list