[PATCH v2] tee: optee: Change printing during optee_probe

Simon Glass sjg at chromium.org
Fri Mar 12 05:45:46 CET 2021

Hi Ilias,

On Wed, 10 Mar 2021 at 06:35, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
> Right now the error messages when optee has a version mismatch or shared
> memory is not configured are done with a debug().
> That's not very convenient since you have to enable debugging to figure
> out what's going on, although this is an actual error.

The code that probes the device should report the error. If you put
errors in a device driver it bloats the code and also it makes it
impossible for the caller to suppress the  error, e.g. if it is OK for
the device to not probe.

> So let's switch the debug() -> dev_err() and report those explicitly.
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> ---
>  drivers/tee/optee/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

More information about the U-Boot mailing list