[PATCH v2 12/21] net: phy: fixed: Support the old DT binding

Vladimir Oltean olteanv at gmail.com
Sat Mar 13 14:19:56 CET 2021


On Fri, Mar 12, 2021 at 09:35:53PM +0800, Bin Meng wrote:
> Update fixedphy_probe() to support the old DT binding.
> 
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> Reviewed-by: Ramon Fried <rfried.dev at gmail.com>
> ---
> 
> (no changes since v1)
> 
>  drivers/net/phy/fixed.c | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
> index 304e506554..ea05a45244 100644
> --- a/drivers/net/phy/fixed.c
> +++ b/drivers/net/phy/fixed.c
> @@ -27,13 +27,27 @@ static int fixedphy_config(struct phy_device *phydev)
>  {
>  	ofnode node = phy_get_ofnode(phydev);
>  	struct fixed_link *priv;
> +	bool old_binding = false;
>  	u32 val;
> +	u32 old_val[5];

Perhaps a pet peeve from Linux networking, but could you please keep the
variable definitions sorted by line length? Thanks.

Reviewed-by: Vladimir Oltean <vladimir.oltean at nxp.com>


More information about the U-Boot mailing list