[PATCH 2/4] pinephone_defconfig: reduce boot delay

Arnaud Ferraris arnaud.ferraris at collabora.com
Sat Mar 13 15:56:12 CET 2021


Hi Maxime,

Le 25/02/2021 à 21:58, Maxime Ripard a écrit :
> On Thu, Feb 25, 2021 at 05:02:40PM +0000, André Przywara wrote:
>> On 20/02/2021 12:14, Nicolas Boulenguez wrote:
>>> From: Arnaud Ferraris <arnaud.ferraris at collabora.com>
>>>
>>> On a cellular phone, the vast majority of users can be expected to
>>> have no serial console connected and prefer a short boot.
>>
>> It's a bit tricky to break in with a delay of 0, but indeed most users
>> won't care, so looks fine to me.
>>
>> But it's missing a Signed-off-by: line.
> 
> I'm not sure we should start accepting custom boards changes like it's
> done here, this will only lead to inconsistencies between boards in the
> long run.

The original reasoning behind this was, the PinePhone (and PineTab) is
both a dev board and a consumer device, which is why I assumed it could
use some kind of "special treatment".

However, I don't have a strong opinion on that matter and can certainly
live with the default boot delay.

Regards,
Arnaud

> 
> And a defconfig is really easy to change anyway, even when it's
> integrated in build systems
> 
> Maxime
> 


More information about the U-Boot mailing list