[PATCH v3 05/22] net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed

Bin Meng bmeng.cn at gmail.com
Sun Mar 14 06:14:53 CET 2021

From: Vladimir Oltean <vladimir.oltean at nxp.com>

In drivers/net/phy/Kconfig, CONFIG_PHY_FIXED already depends on
CONFIG_DM_ETH, so the function prototype definition when
CONFIG_DM_ETH=n does nothing, so it can be dropped. It is also
never reachable, since the whole function is already under #ifdef
CONFIG_PHY_FIXED (which again, as I said, depends on CONFIG_DM_ETH=y).

Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>
Message-Id: <20210216224804.3355044-3-olteanv at gmail.com>
Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean at nxp.com>

(no changes since v1)

 drivers/net/phy/phy.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 2feb559bba..eae40cc0d6 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -1012,15 +1012,9 @@ struct phy_device *fixed_phy_create(ofnode node)
 	return phydev;
 static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
 					    struct udevice *dev,
 					    phy_interface_t interface)
-static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
-					    struct eth_device *dev,
-					    phy_interface_t interface)
 	ofnode node = dev_ofnode(dev), subnode;
 	struct phy_device *phydev;

More information about the U-Boot mailing list