[PATCH 5/6 v2] efidebug: add multiple device path instances on Boot####

[Ilias Apalodimas]

On Sun, Mar 14, 2021 at 10:42:06AM +0100, Heinrich Schuchardt wrote:
> On 3/14/21 10:27 AM, Heinrich Schuchardt wrote:
> > On 3/13/21 10:47 PM, Ilias Apalodimas wrote:
> > > The UEFI spec allow a packed array of UEFI device paths in the
> > 
> > %s/allow/allows/
> > 
> > > FilePathList[] of an EFI_LOAD_OPTION. The first file path must
> > > describe the loaded image but the rest are OS specific.
> > > 
> > > Previous patches parse the device path and try to use the second
> > > member of the array as an initrd. So let's modify efidebug slightly
> > > and install the second file described in the command line as the
> > > initrd device path.
> > > 
> > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> 
> <snip />
> 
> > > index 70d6be00e8a8..0849572a5143 100644
> > > --- a/test/py/tests/test_efi_secboot/test_signed_intca.py
> > > +++ b/test/py/tests/test_efi_secboot/test_signed_intca.py
> > > @@ -39,7 +39,7 @@ class TestEfiSignedImageIntca(object):
> > >               assert 'Failed to set EFI variable' not in ''.join(output)
> > > 
> > >               output = u_boot_console.run_command_list([
> > > -                'efidebug boot add 1 HELLO_a host 0:1
> > > /helloworld.efi.signed_a ""',
> > > +                'efidebug boot add -b 1 HELLO_a host 0:1
> >> /helloworld.efi.signed_a ""',
> >>                   'efidebug boot next 1',
> >>                   'efidebug test bootmgr'])
> 
> Why don't we use as syntax
> 'efidebug boot add HELLO_a -b 1 host 0:1 helloworld.efi.signed_a'?
> 
> The boot option number and label are not a property of the binary.

I just moved all aof the args we had when adding an executable to -b, since
those are need to define a boot option
> 
> Best regards
> 
> Heinrich