[PATCH v8 03/28] bus: ti: add minimal sysc interconnect target driver

[Dario Binacchi]

Hi Simon,

> Il 15/03/2021 04:01 Simon Glass <sjg at chromium.org> ha scritto:
> 
>  
> Hi Dario,
> 
> On Wed, 30 Dec 2020 at 12:08, Dario Binacchi <dariobin at libero.it> wrote:
> >
> > We can handle the sysc interconnect target module in a generic way for
> > many TI SoCs. Initially let's just enable domain clocks before the
> > children are probed.
> >
> > The code is loosely based on the drivers/bus/ti-sysc.c of the Linux
> > kernel version 5.9-rc7.
> > For DT binding details see:
> > - Documentation/devicetree/bindings/bus/ti-sysc.txt
> >
> > Signed-off-by: Dario Binacchi <dariobin at libero.it>
> >
> > ---
> >
> > Changes in v8:
> > - Imply CONFIG_TI_SYSC only if CONFIG_DM and CONFIG_OF_CONTROL are enabled.
> > - Revert change on cm_t335_defconfig added on version 7 of the series.
> >
> > Changes in v7:
> > - Not all OMAP2 platform need CONFIG_TI_SYSC.
> >   Set CONFIG_TI_SYSC as imply and disable it to fix building errors in:
> >    nokia_rx51_defconfig
> >    cm_t335_defconfig
> >
> > Changes in v4:
> > - Include device_compat.h header for dev_xxx macros.
> >
> >  arch/arm/Kconfig             |   1 +
> >  configs/nokia_rx51_defconfig |   1 +
> >  drivers/bus/Kconfig          |   7 ++
> >  drivers/bus/Makefile         |   1 +
> >  drivers/bus/ti-sysc.c        | 166 +++++++++++++++++++++++++++++++++++
> >  5 files changed, 176 insertions(+)
> >  create mode 100644 drivers/bus/ti-sysc.c
> 
> This patch defines a duplicate uclass driver for UCLASS_SIMPLE_BUS
> which is not allowed. This breaks of-platdata and makes the result
> non-deterministic.
> 
> Can you please change it to be a normal driver instead, not a uclass
> driver? If you need your own uclass, then you should create one.

Let me do some tests and I will send the patch as soon as possible.

Thanks and regards,
Dario

> 
> +Tom Rini also as this affects the upcoming release.
> 
> Regards,
> Simon