[PATCH v2] bus: ti-sysc: change in a normal driver

Simon Glass sjg at chromium.org
Wed Mar 17 19:30:38 CET 2021


On Wed, 17 Mar 2021 at 09:51, Dario Binacchi <dariobin at libero.it> wrote:
>
> The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, but
> it is not allowed. This breaks of-platdata and makes the result
> non-deterministic.
>
> The driver does not need to be an uclass driver, so lets remove it. I
> had turned it into an uclass driver because I thought wrongly it had to
> call the dm_scan_fdt_dev routine to work properly, but some tests on the
> board have shown otherwise.
>
> Signed-off-by: Dario Binacchi <dariobin at libero.it>
>
> ---
>
> Changes in v2:
> - Remove UCLASS_SYSC id.
> - Change ti-sysc in a normal driver instead of an uclass driver.
>   Previous tests, where I had removed the uclass driver, failed because
>   I added the dm_scan_fdt_dev routine to the driver bind routine (I moved
>   it from the uclass driver post_bind routine to the normal driver bind
>   one).
>
>  drivers/bus/ti-sysc.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

Thank you!


More information about the U-Boot mailing list