[BUG] sandbox error handling broken on origin/next

[Simon Glass]

Hi Heinrich,

On Tue, 23 Mar 2021 at 07:12, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Hello Simon,
>
> using sandbox_defconfig on origin/master:
>
> Hit any key to stop autoboot:  0
> => exception sigsegv
>
> Segmentation violation
> pc = 0x55d3566d04f9, pc_reloc = 0x554f9
>
> $
>
> Here the SIGSEGV is correctly handled by the sandbox.
>
> On origin/next:
>
> => exception sigsegv
>
> Segmentation violation
> pc = 0x5567966da96b, pc_reloc = 0x5567866da96b
>
> Writing sandbox state
> Segmentation fault
> $
>
> The same problem is visible when executing the poweroff command.
>
> => poweroff
> poweroff ...
> Segmentation fault
> $
>
> Bisecting points to your commit
>
> b308d9fd18fa
> sandbox: Avoid using malloc() for system state
>
> The segmentation fault occurs when os_exit() calls dm_uninit().
> The value of gd is invalid at this point.

Can you please check this patch?

http://patchwork.ozlabs.org/project/uboot/patch/20210315051124.1940496-10-sjg@chromium.org/

Also, is there no test covering the above?

Regards,
Simon