[PATCH v1 08/23] phy: marvell: add RX training command

[Marek Behun]

On Wed, 24 Mar 2021 15:06:34 +0100
Stefan Roese <sr at denx.de> wrote:

> From: Igal Liberman <igall at marvell.com>
> 
> This patch adds support for running RX training using new command called
> "rx_training"
> Usage:
> rx_training - rx_training <cp id> <comphy id>
> 
> RX training allows to improve link quality (for SFI mode)
> by running training sequence between us and the link partner,
> this allows to reach better link quality then using static configuration.

PLEASE do not add another vendor specific command. PLEASE !

Create a generic command, with name 'ddr' or something, with API and
documentation.

Also the name "rx_training" is the worst thing ever. It could be
interpreted as training for RX on ethernet PHY, or even on UART.

Maybe people from Marvell could work more on their cooperation with
community. It is not terrible, but it is bad. There are hundreds if not
thousand of patches in their SDKs for both U-Boot and Linux. It is a
nightmare.

Marek