[PATCH 12/19] sf: Support querying write-protect

Simon Glass sjg at chromium.org
Sat Mar 27 04:17:45 CET 2021

This feature was dropped from U-Boot some time ago:

   f12f96cfaf5 (sf: Drop spl_flash_get_sw_write_prot")

However, we do need a way to see if a flash device is write-protected,
since if it is, it may not be possible to write to do (i.e. failing to
write is expected).

I am not sure of the correct layer to implement this, so this patch is a
stab at it. If spi-flash makes sense then I will add to the 'sf' also.

Re the points mentioned in the removal commit:

    1) This kind of requirement can be achieved using existing
       flash operations and flash locking API calls instead of
       making a separate flash API.

Which uclass is this?

    2) Technically there is no real hardware user for this API to
       use in the source tree.

I do want coral (at least) to support this.

    3) Having a flash operations API for simple register read bits
       also make difficult to extend the flash operations.

This new patch only mentions write-protect being on or off, rather than
the actual mechanism.

    4) Instead of touching generic code, it is possible to have
       this functionality inside spinor operations in the form of
       flash hooks or fixups for associated flash chips.

That sounds to me like what drivers are for. But we still need some sort
of API for it to be accessible.

Signed-off-by: Simon Glass <sjg at chromium.org>

 drivers/mtd/spi/sf-uclass.c    |  9 +++++++++
 drivers/mtd/spi/sf_internal.h  |  4 ++++
 drivers/mtd/spi/sf_probe.c     |  8 ++++++++
 drivers/mtd/spi/spi-nor-core.c | 11 +++++++++++
 drivers/mtd/spi/spi-nor-tiny.c |  6 ++++++
 include/spi_flash.h            | 27 +++++++++++++++++++++++++++
 test/dm/sf.c                   | 10 +++++++++-
 7 files changed, 74 insertions(+), 1 deletion(-)

Applied to u-boot-dm/next, thanks!

More information about the U-Boot mailing list