[PATCH 1/1] fs: fat: fix file_fat_detectfs()

Heinrich Schuchardt xypron.glpk at gmx.de
Sun Mar 28 14:23:44 CEST 2021

On 3/28/21 4:05 AM, Simon Glass wrote:
> On Sun, 28 Mar 2021 at 01:06, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> Up to now file_fat_detectfs() did not detect some interface types like
>> Avoid duplicate code by calling blk_get_if_type_name().
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>   fs/fat/fat.c | 36 ++----------------------------------
>>   1 file changed, 2 insertions(+), 34 deletions(-)
> This is lower case I think, but probably that is better anyway.
> Reviewed-by: Simon Glass <sjg at chromium.org>

Thanks for reviewing.

Yes, if_typename_str[] is lowercase. So the case in the output changes.
We should avoid different case in different use cases. So this change is

There is nothing FAT specific in command 'fatinfo'. Shouldn't we better
move it to cmd/fs.c and call it 'fsinfo'?

Best regards


More information about the U-Boot mailing list