[PATCH v2 04/10] net: mvpp2: remove redundant SMI address configuration
Ramon Fried
rfried.dev at gmail.com
Mon May 3 21:41:19 CEST 2021
On Mon, May 3, 2021 at 9:08 AM Stefan Roese <sr at denx.de> wrote:
>
> From: Marcin Wojtas <mw at semihalf.com>
>
> Because the mvpp2 driver now relies on the PHYLIB and
> the external MDIO driver, configuring low level
> SMI bus settings is redundant.
>
> Signed-off-by: Marcin Wojtas <mw at semihalf.com>
> Reviewed-by: Kostya Porotchkin <kostap at marvell.com>
> Reviewed-by: Stefan Chulski <stefanc at marvell.com>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>
> (no changes since v1)
>
> drivers/net/mvpp2.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
> index 847007d5b487..2043bdf10aa4 100644
> --- a/drivers/net/mvpp2.c
> +++ b/drivers/net/mvpp2.c
> @@ -5292,14 +5292,6 @@ static int mvpp2_write_hwaddr(struct udevice *dev)
> return mvpp2_prs_update_mac_da(port, port->dev_addr);
> }
>
> -static int mvpp22_smi_phy_addr_cfg(struct mvpp2_port *port)
> -{
> - writel(port->phyaddr, port->priv->iface_base +
> - MVPP22_SMI_PHY_ADDR_REG(port->gop_id));
> -
> - return 0;
> -}
> -
> static int mvpp2_base_probe(struct udevice *dev)
> {
> struct mvpp2 *priv = dev_get_priv(dev);
> @@ -5422,10 +5414,6 @@ static int mvpp2_probe(struct udevice *dev)
> port->base = priv->iface_base + MVPP22_PORT_BASE +
> port->gop_id * MVPP22_PORT_OFFSET;
>
> - /* Set phy address of the port */
> - if (port->phyaddr < PHY_MAX_ADDR)
> - mvpp22_smi_phy_addr_cfg(port);
> -
> /* GoP Init */
> gop_port_init(port);
> }
> --
> 2.31.1
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>
More information about the U-Boot
mailing list