[RFC 4/7] pinctrl: mscc: Fix multiple definition error

Horatiu Vultur horatiu.vultur at microchip.com
Tue May 4 09:51:57 CEST 2021


The 05/03/2021 16:48, Tom Rini wrote:
> 
> With gcc-11 we get a multiple errors here as the declarations for
> mscc_pinctrl_ops and mscc_gpio_ops are missing an extern.

Reviewed-by: Horatiu Vultur <horatiu.vultur at microchip.com>

> 
> CC: Gregory CLEMENT <gregory.clement at bootlin.com>
> Cc: Lars Povlsen <lars.povlsen at microchip.com>
> Cc: Horatiu Vultur <horatiu.vultur at microchip.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  drivers/pinctrl/mscc/mscc-common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/mscc/mscc-common.h b/drivers/pinctrl/mscc/mscc-common.h
> index 3c5c1faf840f..49c84a9f410b 100644
> --- a/drivers/pinctrl/mscc/mscc-common.h
> +++ b/drivers/pinctrl/mscc/mscc-common.h
> @@ -61,6 +61,6 @@ int mscc_pinctrl_probe(struct udevice *dev, int num_func,
>                        const struct mscc_pin_data *mscc_pins, int num_pins,
>                        char * const *function_names,
>                        const unsigned long *mscc_gpios);
> -const struct pinctrl_ops mscc_pinctrl_ops;
> +extern const struct pinctrl_ops mscc_pinctrl_ops;
> 
> -const struct dm_gpio_ops mscc_gpio_ops;
> +extern const struct dm_gpio_ops mscc_gpio_ops;
> --
> 2.17.1
> 

-- 
/Horatiu


More information about the U-Boot mailing list