[PATCH] pinctrl: mscc: fix multiple definitions

Tom Rini trini at konsulko.com
Tue May 4 20:45:18 CEST 2021


On Tue, May 04, 2021 at 08:40:40PM +0200, Daniel Schwierzeck wrote:

> gcc-11 complains about multiple definitions:
> 
> /opt/gcc-11.0.20210426-nolibc/mips-linux/bin/mips-linux-ld.bfd: drivers/pinctrl/mscc/pinctrl-ocelot.o:drivers/pinctrl/mscc/mscc-common.h:64: multiple definition of `mscc_pinctrl_ops'; drivers/pinctrl/mscc/mscc-common.o:drivers/pinctrl/mscc/mscc-common.h:64: first defined here
> /opt/gcc-11.0.20210426-nolibc/mips-linux/bin/mips-linux-ld.bfd: drivers/pinctrl/mscc/pinctrl-ocelot.o:drivers/pinctrl/mscc/mscc-common.h:66: multiple definition of `mscc_gpio_ops'; drivers/pinctrl/mscc/mscc-common.o:drivers/pinctrl/mscc/mscc-common.h:66: first defined here
> 
> mscc_pinctrl_ops and mscc_gpio_ops are instantiated in mscc-common.c and
> just referenced by SoC specific pinctrl drivers. Annotate the exports
> in mscc-common.h with `extern` to avoid creating new instances
> when including mscc-common.h.
> 
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>

I posted this yesterday as part of:
https://patchwork.ozlabs.org/project/uboot/list/?series=241916&state=*
BTW.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210504/c06bb22d/attachment.sig>


More information about the U-Boot mailing list