[PATCH] common: fdt_support: Observe index in fdt_getprop_u32_default_node()

Simon Glass sjg at chromium.org
Wed May 5 20:48:49 CEST 2021

Hi Andre,

On Wed, 5 May 2021 at 06:50, Andre Przywara <andre.przywara at arm.com> wrote:
> fdt_getprop_u32_default_node() promises to take the "cell" number into
> account when returning the value of a property array.
> However it actually misses out on this, always returning the first cell
> only instead. This was so far not a problem, since every user always
> asks for cell 0.
> Observe the index value when accessing the property, and also fix the
> parameter names to the more commonly used propname, offset and index
> names, to improve readability of the function.
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
>  common/fdt_support.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Can you please add a test while you are here?


More information about the U-Boot mailing list