[PATCH 08/17] test: Avoid random numbers in dm_test_devm_regmap()
Simon Glass
sjg at chromium.org
Sun May 9 00:00:12 CEST 2021
There is no good reason to use a sequence from rand() here. We may as well
invent our own sequence.
This should molify Coverity which does not use rand() being used.
Signed-off-by: Simon Glass <sjg at chromium.org>
Reported-by: Coverity (CID: 312949)
---
test/dm/regmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/test/dm/regmap.c b/test/dm/regmap.c
index 372a73ca0c3..04bb1645d1b 100644
--- a/test/dm/regmap.c
+++ b/test/dm/regmap.c
@@ -306,9 +306,8 @@ static int dm_test_devm_regmap(struct unit_test_state *uts)
&dev));
priv = dev_get_priv(dev);
- srand(get_ticks() + rand());
for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) {
- pattern[i] = rand();
+ pattern[i] = i * 0x87654321;
ut_assertok(regmap_write(priv->cfg_regmap, i, pattern[i]));
}
for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) {
--
2.31.1.607.g51e8a6a459-goog
More information about the U-Boot
mailing list