[PATCH] efi_loader: Clean up tcg2 once in case of failure

[Heinrich Schuchardt]

On 5/10/21 8:15 PM, Ilias Apalodimas wrote:
> efi_init_event_log() calls tcg2_uninit() in case of failure.
> We can skip that since the function is called on efi_tcg2_register()
> which also cleans up if an error occurs
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>   lib/efi_loader/efi_tcg2.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
> index 94e8f22bbb69..570cc746ed4e 100644
> --- a/lib/efi_loader/efi_tcg2.c
> +++ b/lib/efi_loader/efi_tcg2.c
> @@ -1053,12 +1053,8 @@ static efi_status_t efi_init_event_log(void)
>   	event_log.last_event_size = event_log.pos;
>
>   	ret = create_final_event();
> -	if (ret != EFI_SUCCESS)
> -		goto out;
>
> -	return EFI_SUCCESS;
>   out:
> -	tcg2_uninit();
>   	return ret;
>   }
>
>