[PATCH v2 16/50] image: Add Kconfig options for FIT in the host build

Alex G. mr.nuke.me at gmail.com
Wed May 12 17:48:53 CEST 2021



On 5/12/21 9:51 AM, Simon Glass wrote:
> Hi Alex,
> 
> On Tue, 11 May 2021 at 13:57, Alex G. <mr.nuke.me at gmail.com> wrote:
>>
>> On 5/6/21 9:24 AM, Simon Glass wrote:

[snip]

>>
>>> +
>>> +config HOST_FIT_PRINT
>>> +     def_bool y
>>> +     help
>>> +       Print the content of the FIT verbosely in the host build
>>
>> This option also doesn't make sense.This seems to do what 'mkimage -l'
>> already supports.
> 
> Are you sure you have looked at the goal of the CONFIG_IS_ENABLED()
> changes? This is here purely to avoid #ifdefs in the share code.

On the one hand, we have the cosmetic inconvenience caused by #ifdefs. 
On the other hand we have the config system. To most users, the config 
system is likely more visible, while it's mostly developers who will 
ever see the ifdefs.

Therefore, in order to get the developer convenience of less ifdefs, we 
have to sacrifice user convenience by cloberring the Kconfig options. I 
think this is back-to-front.

Can we reduce the host config count to just SLL/NOSSL?

Alex


More information about the U-Boot mailing list