[PATCH] Fix flash and erase of EMMC_BOOT2 with fastboot

Roman Stratiienko r.stratiienko at gmail.com
Thu May 13 10:58:54 CEST 2021


Looks like there is another issue:
Erasing the USER partition (CONFIG_FASTBOOT_MMC_USER_SUPPORT), will
erase active selected hwpart, and in case it was called after
erasing/flashing BOOT1 & BOOT2 it will erase last selected boot
partition, instead of USER.

чт, 13 мая 2021 г. в 11:42, Roman Stratiienko <r.stratiienko at gmail.com>:
>
> Hi Oleh,
>
> Thank you for the fix.
>
> Reviewed-by: Roman Stratiienko <r.stratiienko at gmail.com>
>
> чт, 13 мая 2021 г. в 01:44, Oleh Kravchenko <oleg at kaa.org.ua>:
> >
> > The current U-Boot version has the next matches for boot partitions:
> > > mmc0boot0 to EMMC_BOOT1
> > > mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
> > This patch fixes a typo for the boot partition number.
> >
> > Signed-off-by: Oleh Kravchenko <oleg at kaa.org.ua>
> > Cc: Pantelis Antoniou <panto at antoniou-consulting.com>
> > Cc: Marek Vasut <marex at denx.de>
> > ---
> >
> >  drivers/fastboot/fb_mmc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
> > index 8e74e50e91..1827ce5d12 100644
> > --- a/drivers/fastboot/fb_mmc.c
> > +++ b/drivers/fastboot/fb_mmc.c
> > @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
> >         if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
> >                 dev_desc = fastboot_mmc_get_dev(response);
> >                 if (dev_desc)
> > -                       fb_mmc_boot_ops(dev_desc, download_buffer, 1,
> > +                       fb_mmc_boot_ops(dev_desc, download_buffer, 2,
> >                                         download_bytes, response);
> >                 return;
> >         }
> > @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response)
> >                 /* erase EMMC boot2 */
> >                 dev_desc = fastboot_mmc_get_dev(response);
> >                 if (dev_desc)
> > -                       fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
> > +                       fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response);
> >                 return;
> >         }
> >  #endif
> > --
> > 2.26.3
> >


More information about the U-Boot mailing list