[PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

Bin Meng bmeng.cn at gmail.com
Thu May 13 14:11:07 CEST 2021


Hi Sean,

On Sun, May 9, 2021 at 12:24 AM Sean Anderson <seanga2 at gmail.com> wrote:
>
> On 5/8/21 12:22 PM, Bin Meng wrote:
> > On Sun, May 9, 2021 at 12:13 AM Sean Anderson <seanga2 at gmail.com> wrote:
> >>
> >> If /chosen was missing, chosen_offset would never get updated with the new
> >> /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes
> >> this by setting chosen_offset. In addition, log any errors from setting
> >> boot-hartid as well.
> >>
> >> Fixes: 177c53fe6c6 ("riscv: Move all fdt fixups together")
> >
> > I think the correct commit id to fix is:
> > commit 5370478d1c7afb8b2a8a0a00b31ff97c3a2c0451 ("riscv: Add boot
> > hartid to device tree")
>
> Ah, so it is.
>

Would you send v2 with the correct commit id?

Regards,
Bin


More information about the U-Boot mailing list