[PATCH 1/2] clk: scmi: register all scmi clock by name with CCF

Simon Glass sjg at chromium.org
Sat May 15 17:20:04 CEST 2021


On Wed, 12 May 2021 at 08:55, Etienne Carriere
<etienne.carriere at linaro.org> wrote:
> From: Patrick Delaunay <patrick.delaunay at st.com>
> This patch implements SCMI APIs to retrieve the number and the name of
> SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages.
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez at st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere at linaro.org>
> ---
>  drivers/clk/clk_scmi.c   | 101 +++++++++++++++++++++++++++++++++++++++
>  include/scmi_protocols.h |  43 +++++++++++++++++
>  2 files changed, 144 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

I notice that this code uses pointers to return error codes. We tend
to avoid that in U-Boot and use an integer return instead, with the
pointer returned as a parameter. We have things like log_msg_ret() to
help with that. I don't have strong feelings about this if the goal is
to make the code match linux code. But if this code is for U-Boot
only, please do avoid it.


More information about the U-Boot mailing list