[PATCH 09/12] net: ti: am65-cpsw-nuss: Don't cache disabled port ID

Ramon Fried rfried.dev at gmail.com
Sat May 15 21:50:42 CEST 2021


On Mon, May 10, 2021 at 5:37 PM Vignesh Raghavendra <vigneshr at ti.com> wrote:
>
> Currently driver may end up caching disabled port ID as active
> interface. Fix this by bailing out earlier in case port is marked
> disabled in the DT.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>
> ---
>  drivers/net/ti/am65-cpsw-nuss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c
> index 9f11ce63b9..3534a6d807 100644
> --- a/drivers/net/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ti/am65-cpsw-nuss.c
> @@ -719,11 +719,11 @@ static int am65_cpsw_probe_cpsw(struct udevice *dev)
>                 if (!port_id)
>                         continue;
>
> -               priv->port_id = port_id;
>                 cpsw_common->ports[port_id].disabled = disabled;
>                 if (disabled)
>                         continue;
>
> +               priv->port_id = port_id;
>                 ret = am65_cpsw_ofdata_parse_phy(dev, node);
>                 if (ret)
>                         goto out;
> --
> 2.31.1
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list