[PATCH 1/1] test: revert Don't unmount not (yet) mounted system

[Heinrich Schuchardt]

On 17.05.21 13:16, Andy Shevchenko wrote:
> On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote:
>> On 17.05.21 08:33, Andy Shevchenko wrote:
>>> On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>>>
>>>> Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system")
>>>> the following tests are skipped:
>>>>
>>>> test/py/tests/test_fs/test_basic.py
>>>> test/py/tests/test_fs/test_ext.py
>>>>
>>>> SKIPPED [13] test/py/tests/test_fs/conftest.py:350: Setup failed for
>>>> filesystem: ext4. Command 'guestmount -a
>>>> build-sandbox/persistent-data/3GB.ext4.img -m /dev/sda
>>>> build-sandbox/persistent-data/mnt' returned non-zero exit status 1.
>>>>
>>>> Let's revert the patch to get our tests back.
>>>
>>> Probably we may understand first what is the root cause of this issue?
>>>
>>> In my case I can't allow this to happen, because it will annoy system
>>> administrators as I mentioned earlier in the commit message.
>>>
>>> So, NAK from me and let's investigate.
>>> Can you provide a command line that I may run on my environment w/o root access?
>>
>> Hello Andy,
>>
>> The tests don't require root access if you have installed the
>> libguestfs-tools package and a Linux kernel.
>>
>> How can I reproduce the problem with duplicate umount?
>
> I was running this 2+ times in a row (*)
>
> ./test/py/test.py --bd sandbox --build
>
> *) I can't run tests right now due to they are more or less constantly broken
> one way or the other, now
>
> ============================================== test session starts ==============================================
> platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0
> rootdir: /home/andy/prj/u-boot/test/py, configfile: pytest.ini
> collected 810 items / 1 error / 809 selected
>
> ___________________________________ ERROR collecting tests/test_fit_ecdsa.py ____________________________________
> E   ModuleNotFoundError: No module named 'Cryptodome'

The missing package is available via

    apt-get install python3-pycryptodome # Debian/Ubuntu

or

    dnf install python3-pycryptodomex # Fedora

Best regards

Heinrich

>
>
> And suddenly this is a fatal error for unknown reason.
>
> I will check later when I have time how to work around, or if meanwhile
> somebody tells me what are the steps to fix it.
>
> I'm using v2021.07-rc2
>