[PATCH] sandbox: cros-ec: Add tests for the cros-ec-pwm driver

Alper Nebi Yasak alpernebiyasak at gmail.com
Wed May 19 17:28:17 CEST 2021

On 16/05/2021 23:05, Heinrich Schuchardt wrote:
> Am 16. Mai 2021 17:41:44 MESZ schrieb Alper Nebi Yasak <alpernebiyasak at gmail.com>:
>> This patch lets sandbox-cros-ec emulate a limited pwm device which has
>> multiple channels but can only set a duty cycle for each, as the actual
>> EC doesn't expose any functionality or information other than that.
>> Mapping non-generic EC_PWM_TYPE_* values to these emulated pwm channels
>> is not implemented as nothing in U-Boot uses these types.
> This commit messages is full of of abbreviations which makes it unclear. Please, use human readable terms.
> I guess you might be talking about
> Chromium OS
> Embedded Controller
> Pulse Width Modulation
> But I am not sure.

Those are pretty much correct. I'm sending a v2 with hopefully a clearer
commit message.

> Best regards
> Heinrich
>> This emulated pwm is then used to test the cros-ec-pwm driver in
>> sandbox. Adding the cros-ec-pwm node to the sandbox test device-tree
>> unfortunately makes it the first pwm device, so this also touches some
>> other tests to make sure they still use the sandbox pwm.
>> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>

More information about the U-Boot mailing list