[PATCH 0/8] sunxi: mmc: Fixes and speed increase
andre.przywara at arm.com
Tue May 25 01:30:21 CEST 2021
While debugging some eMMC problem on the H616 SoC, I stumbled upon some
weird code in the Allwinner MMC driver. Some closer inspection and some
help from Ondrej later this series of fixes emerged:
Some patches remove part of the #ifdef hell we needlessly had in the
A big chunk is around the "new timing mode", which all "newer" SoCs
(since around 2015) have, and which requires some extra bit to be set. We
didn't enable this mode for all SoCs, this is now fixed in patches 3-6.
Patch 7 fixes a big performance problem we had due to using MMIO accesses
for the actual data transfer, as opposed to DMA transfers used in Linux.
Short from adding a lot of code to use DMA as well, we can actually halve
the number of MMIO accesses on reads, effectively doubling the bus
transfer performance. This helps the H6 a lot, but also improves the eMMC
The final patch makes use of some generic MMC DT code, to parse generic
DT properties. This allows us to remove sunxi specific code, but also
adds support for "broken-cd" and more advanced MMC speed modes.
Please have a look and test this code on as many boards as possible.
While a performance increase is nice, we don't want to risk data
integrity over this, so please try to verify that it still works for
P.S. Patches 5 and 6 use different approaches to differentiate between
SoCs specific quirks: Patch 5/8 selects an explicit symbol from the
SoC specific sections in our Kconfig file, while patch 6/8 compares
the selected SoC type in the C code. Please let me know which approach
is better, I can then use this for both patches (and in the future).
Andre Przywara (8):
mmc: sunxi: Avoid #ifdefs in delay and width setup
mmc: sunxi: Fix warnings with CONFIG_PHYS_64BIT
mmc: sunxi: Fix MMC clock parent selection
mmc: sunxi: Cleanup "new timing mode" selection
mmc: sunxi: Enable "new timing mode" on all new SoCs
mmc: sunxi: Cleanup and fix self-calibration code
mmc: sunxi: Increase MMIO FIFO read performance
mmc: sunxi: Use mmc_of_parse()
.../include/asm/arch-sunxi/clock_sun50i_h6.h | 2 +-
arch/arm/include/asm/arch-sunxi/mmc.h | 1 +
arch/arm/mach-sunxi/Kconfig | 3 +
drivers/mmc/sunxi_mmc.c | 160 +++++++++++-------
4 files changed, 102 insertions(+), 64 deletions(-)
More information about the U-Boot