[PATCH 1/3] test/py: rewrite common tools for SquashFS tests

João Marcos Costa jmcosta944 at gmail.com
Sat May 29 20:14:13 CEST 2021


Hello,

Em qui., 27 de mai. de 2021 às 10:44, Simon Glass <sjg at chromium.org>
escreveu:

> Hi Joao,
>
> On Sun, 23 May 2021 at 20:31, Joao Marcos Costa <jmcosta944 at gmail.com>
> wrote:
> >
> > Remove the previous OOP approach, which was confusing and incomplete.
> > Add more test cases by making SquashFS images with various options,
> > concerning file fragmentation and its compression. Add comments to
> > properly document the code.
> >
> > Signed-off-by: Joao Marcos Costa <jmcosta944 at gmail.com>
> > ---
> [...]
>
> While we are here, can you please be a little more formal with your
> function comments? pylint3 will tell you about it if you run it on
> this file.
>
> [...]
>
> Regards,
> Simon
>

Absolutely, Simon, and thanks for suggesting pylint3!

-- 
Atenciosamente,
João Marcos Costa

www.linkedin.com/in/jmarcoscosta/
https://github.com/jmarcoscosta


More information about the U-Boot mailing list