[PATCH v2 0/3] test/py: Rewrite SquashFS commands test suite

Joao Marcos Costa jmcosta944 at gmail.com
Sun May 30 02:09:35 CEST 2021


This patch series fixes the following issues:
- poor strategy to check if files were properly loaded
- wrong quoting style for strings
- tests failing at the second run because of a wrong clean-up strategy

Finally, it improves:
- code overall documentation level, with more comments and better
  naming for functions and variables
- code readability by adding more helper functions
- completeness: more test cases were added for both sqfsls and sqfsload

The sqfsload new test suite may fail when testing images with fragmented
files if the patch I previously sent (fs/squashfs: fix reading of
fragmented files) is not applied, so this patch series depends on it.

Changes since V1:
- Leave the copyright year as it was (2020) instead of changing it to
- Remove spurious comments and print statements
- Fix the style issues pointed by pylint3

Best regards,

Joao Marcos Costa (3):
  test/py: rewrite common tools for SquashFS tests
  test/py: rewrite sqfsload command test suite
  test/py: rewrite sqfsls command test suite

 .../test_fs/test_squashfs/sqfs_common.py      | 237 +++++++++++++-----
 .../test_fs/test_squashfs/test_sqfs_load.py   | 166 +++++++++---
 .../test_fs/test_squashfs/test_sqfs_ls.py     | 138 ++++++++--
 3 files changed, 428 insertions(+), 113 deletions(-)


More information about the U-Boot mailing list