[BUG] Spurious error in Gitlab CI for sandbox_spl test.py

[Simon Glass]

Hi Heinrich,

On Wed, 27 Oct 2021 at 23:17, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Hello Tom,
>
> we have some trouble with Gitlab CI:
>
> In https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/342220
>
>     sandbox:  +   sandbox_spl
> +/usr/bin/ld: /tmp/u-boot-spl.Z4D5y0.ltrans0.ltrans.o: in function
> `dm_setup_inst.lto_priv.0':
> +drivers/core/root.c:134: undefined reference to
> `_u_boot_list_2_udevice_2_root'
> +/usr/bin/ld:
> /tmp/u-boot-spl.Z4D5y0.ltrans0.ltrans.o:(.u_boot_list_2_uclass_2_irq+0x10):
> undefined reference to `_u_boot_list_2_udevice_2_irq_sbox'
> +/usr/bin/ld:
> /tmp/u-boot-spl.Z4D5y0.ltrans0.ltrans.o:(.u_boot_list_2_uclass_2_irq+0x18):
> undefined reference to `_u_boot_list_2_udevice_2_irq_sbox'
>
> Repeating the job showed no error:
>
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/342252

This seems to be in the code generated by dtoc. Specifically the
dt-device.c file appears to be empty, but the dt-uclass.c file is not.
There is some weird code in Makefile.spl to try to deal with changing
from OF_PLATDATA_INST to !OF_PLATDATA_INST. I suspect there is
something wrong with it, but I'm not sure what, For one thing
u-boot-spl-old-platdata_c is not needed now. The parallel rule (look
for &:) might need a look too.

Regards,
Simon