[PATCH v4 01/16] crypto/fsl: Add support for CAAM Job ring driver model

[Simon Glass]

Hi Gaurav,

On Tue, 26 Oct 2021 at 00:56, Gaurav Jain <gaurav.jain at nxp.com> wrote:
>
> added device tree support for job ring driver.
> sec is initialized based on job ring information processed
> from device tree.
>
> Signed-off-by: Gaurav Jain <gaurav.jain at nxp.com>
> Reviewed-by: Ye Li <ye.li at nxp.com>
> ---
>  cmd/Kconfig                 |   1 +
>  drivers/crypto/fsl/Kconfig  |   7 +
>  drivers/crypto/fsl/Makefile |   4 +-
>  drivers/crypto/fsl/jr.c     | 318 ++++++++++++++++++++++++------------
>  drivers/crypto/fsl/jr.h     |  14 ++
>  5 files changed, 234 insertions(+), 110 deletions(-)

You should not have CONFIG_ARCH_IMX8 in a driver. Things like that
should be handled by using a different compatible string. Also please
use the livetree API.

I asked about the use of MISC as a uclass earlier. It seems that this
device provides random numbers and perhaps hashing? It is hard to know
since I am not sure where the documentation is in this series. It
seems odd to be modelled as a MISC device. My understanding is that
there are problems with the size in SPL if a different UCLASS is used.
Is that correct? I asked about of-platdata but I didn't see any
comment on that.

This does seem to be a significant clean-up even as it is, though, so
these thoughts could be looked at after this series is applied.

Regards,
Simon