[PATCH 5/5] arm: mvebu: Espressobin: Use new API for setting default env at runtime

Pali Rohár pali at kernel.org
Wed Nov 3 11:48:35 CET 2021


On Tuesday 02 November 2021 08:57:51 Simon Glass wrote:
> On Sun, 31 Oct 2021 at 14:15, Pali Rohár <pali at kernel.org> wrote:
> >
> > On Thursday 28 October 2021 05:28:10 Marek Behún wrote:
> > > diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> > > index 3a69954fcd..3dc6da04f8 100644
> > > --- a/configs/mvebu_espressobin-88f3720_defconfig
> > > +++ b/configs/mvebu_espressobin-88f3720_defconfig
> > > @@ -24,7 +24,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
> > >  CONFIG_DISPLAY_BOARDINFO_LATE=y
> > >  CONFIG_ARCH_EARLY_INIT_R=y
> > >  CONFIG_BOARD_EARLY_INIT_F=y
> > > -CONFIG_BOARD_LATE_INIT=y
> >
> > This would not work. Detection of emmc is done in board_late_init()
> > function and cannot be done earlier as it depends on device
> > initialization. Also in this function is removal of emmc from DM if emmc
> > is not present.
> >
> > >  # CONFIG_CMD_FLASH is not set
> > >  CONFIG_CMD_GPIO=y
> > >  CONFIG_CMD_GPT=y
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>

I was discussing with Marek and this patch needs to be reworked as in
current state it does not work.


More information about the U-Boot mailing list