[PATCH v6 07/12] tools: mkeficapsule: allow for specifying GUID explicitly

[AKASHI Takahiro]

On Tue, Nov 02, 2021 at 08:58:18AM -0600, Simon Glass wrote:
> Hi Takahiro,
> 
> On Mon, 1 Nov 2021 at 18:56, AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:
> >
> > The existing options, "--fit" and "--raw," are only used to put a proper
> > GUID in a capsule header, where GUID identifies a particular FMP (Firmware
> > Management Protocol) driver which then would handle the firmware binary in
> > a capsule. In fact, mkeficapsule does the exact same job in creating
> > a capsule file whatever the firmware binary type is.
> >
> > To prepare for the future extension, the command syntax will be a bit
> > modified to allow users to specify arbitrary GUID for their own FMP driver.
> > OLD:
> >    [--fit <image> | --raw <image>] <capsule file>
> > NEW:
> >    [--fit | --raw | --guid <guid-string>] <image> <capsule file>
> 
> Do these drivers have names?

No, even there is no driver in the upstream tree.

> A guid is not a very friendly thing to
> have to provide.

This feature is expected to be used when a user wants to have his own
custom capsule format, yet using the existing command binary.
It will be very much so when loading a FMP (firmware management
protocol) driver dynamically will be supported in the future.

-Takahiro Akashi


> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > ---
> >  doc/develop/uefi/uefi.rst |  4 +-
> >  doc/mkeficapsule.1        | 26 +++++++++----
> >  tools/mkeficapsule.c      | 78 ++++++++++++++++++++++++++++++---------
> >  3 files changed, 81 insertions(+), 27 deletions(-)
> >
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Regards,
> Simon