[PATCH u-boot-marvell 05/11] tools: kwbimage: Remove unused enums and prototypes

[Stefan Roese]

On 08.11.21 18:12, Marek Behún wrote:
> From: Pali Rohár <pali at kernel.org>
> 
> There are more unused enums and function prototypes. Remove them. The
> function kwbimage_check_params() does not return enum kwbimage_cmd_types,
> but a boolean value returned as int.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Signed-off-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   tools/kwbimage.c |  2 +-
>   tools/kwbimage.h | 22 ----------------------
>   2 files changed, 1 insertion(+), 23 deletions(-)
> 
> diff --git a/tools/kwbimage.c b/tools/kwbimage.c
> index a176b39b08..864625d788 100644
> --- a/tools/kwbimage.c
> +++ b/tools/kwbimage.c
> @@ -1916,7 +1916,7 @@ static int kwbimage_check_params(struct image_tool_params *params)
>   		char *msg = "Configuration file for kwbimage creation omitted";
>   
>   		fprintf(stderr, "Error:%s - %s\n", params->cmdname, msg);
> -		return CFG_INVALID;
> +		return 1;
>   	}
>   
>   	return (params->dflag && (params->fflag || params->lflag)) ||
> diff --git a/tools/kwbimage.h b/tools/kwbimage.h
> index f74767e633..8d37357e5a 100644
> --- a/tools/kwbimage.h
> +++ b/tools/kwbimage.h
> @@ -191,28 +191,6 @@ struct register_set_hdr_v1 {
>   #define OPT_HDR_V1_BINARY_TYPE   0x2
>   #define OPT_HDR_V1_REGISTER_TYPE 0x3
>   
> -enum kwbimage_cmd {
> -	CMD_INVALID,
> -	CMD_BOOT_FROM,
> -	CMD_NAND_ECC_MODE,
> -	CMD_NAND_PAGE_SIZE,
> -	CMD_SATA_PIO_MODE,
> -	CMD_DDR_INIT_DELAY,
> -	CMD_DATA
> -};
> -
> -enum kwbimage_cmd_types {
> -	CFG_INVALID = -1,
> -	CFG_COMMAND,
> -	CFG_DATA0,
> -	CFG_DATA1
> -};
> -
> -/*
> - * functions
> - */
> -void init_kwb_image_type (void);
> -
>   /*
>    * Byte 8 of the image header contains the version number. In the v0
>    * header, byte 8 was reserved, and always set to 0. In the v1 header,
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de