[PATCH] net: phy: realtek: Add tx/rx delay config for 8211e

[Ramon Fried]

On Thu, Nov 4, 2021 at 3:42 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Nov 04, 2021 at 01:40:42PM +0000, Andre Przywara wrote:
> > On Thu, 4 Nov 2021 09:13:49 -0400
> > Tom Rini <trini at konsulko.com> wrote:
> >
> > Hi Tom,
> >
> > > On Tue, Oct 12, 2021 at 09:07:32PM -0500, Samuel Holland wrote:
> > >
> > > > Some boards need to change the tx/rx delay config in order for
> > > > gigabit Ethernet to work.
> > > >
> > > > In Linux commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> > > > delay config"), Realtek documented the bits for overriding the delays
> > > > from the hardware straps.
> > > >
> > > > Copy the logic from linux, so the delay config is set from the PHY's
> > > > interface type (the phy-mode property in the device tree).
> > > >
> > > > This removes the need for a one-off workaround for the Pine A64+ board.
> > > >
> > > > Signed-off-by: Samuel Holland <samuel at sholland.org>
> > > > ---
> > > > This change is needed for the Allwinner D1 Nezha board, which has
> > > > incorrect hardware straps.
> > >
> > > OK, so this breaks my pine64+.  It's the 1GB memory model from the
> > > original Kickstarter with an 8211e on it.  My dhcp just times out now,
> > > with this applied.  Let me know if there's some specifics you want me to
> > > try for debug or talk to me off-list and I can try and setup access to
> > > the board for you.
> >
> > Many thanks for testing and the report. I will have a closer look tonight,
> > I should have quite some boards to be able to reproduce it.
>
> Ah good.  And yes, good news / bad news, this board is now in my
> every-PR local CI HW loop :)
>
> --
> Tom
I'm dropping the patch, will check it again once v2 is uploaded.