[PATCH v2 2/2] board: traverse: add initial Ten64 support

[Tom Rini]

On Wed, Nov 10, 2021 at 04:46:39AM +0000, Mathew McBride wrote:

> The Ten64 is a networking-oriented MiniITX board
> using the NXP LS1088A SoC.
> 
> This patch provides the bare minimum to support
> Ten64 boards under U-Boot for distroboot.
> 
> Some related drivers have not yet been submitted
> and this basic support lacks some of the
> opinionated defaults provided by our firmware
> distribution.
> 
> Signed-off-by: Mathew McBride <matt at traverse.com.au>
> ---
>  arch/arm/Kconfig                   |  16 ++
>  arch/arm/dts/Makefile              |   2 +
>  arch/arm/dts/fsl-ls1088a-ten64.dts | 377 +++++++++++++++++++++++++

What is the status of this dts with upstream Linux?

[snip]
> +CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 earlycon=uart8250,mmio,0x21c0500 ramdisk_size=0x3000000 default_hugepagesz=2m hugepagesz=2m hugepages=256"

Note that ramdisk information will be passed along correctly via DT and
should not generally be set in this manner.

[snip]
> +CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-nand0:8m(reserved),32m(recovery),108m(ubia),108m(ubib);nor1:1m(bl2),2m(bl3),2m(mcfirmware),512k(ubootenv),256k(dpl),256k(dpc),256k(devicetree)"

This should be the same as the fixed-partition in the dts and then not
needed here.
> diff --git a/include/configs/ten64.h b/include/configs/ten64.h
> new file mode 100644
> index 0000000000..54e65f29f1
> --- /dev/null
> +++ b/include/configs/ten64.h

Please make sure there's no already migrated CONFIG symbols in this.  A
quick 'git log configs' should make it clear what's been migrated to
Kconfig since you last checked this.

> +#define QSPI_NOR_BOOTCOMMAND	"run distro_bootcmd"
> +#define SD_BOOTCOMMAND		"run distro_bootcmd"

You should just set CONFIG_USE_BOOTCOMMAND and then CONFIG_BOOTCOMMAND
will be "run distro_bootcmd".  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20211111/42dfc662/attachment.sig>