[PATCH v3 15/18] pxe: Return the file size from the getfile() function

Tom Rini trini at konsulko.com
Fri Nov 12 16:40:17 CET 2021


On Thu, Oct 14, 2021 at 12:48:08PM -0600, Simon Glass wrote:

> It is pretty strange that the pxe code uses the 'filesize' environment
> variable find the size of a file it has just read.
> 
> Partly this is because it uses the command-line interpreter to parse its
> request to load the file.
> 
> As a first step towards unwinding this, return it directly from the
> getfile() function. This makes the code a bit longer, for now, but will be
> cleaned up in future patches.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Artem Lapkin <email2tema at gmail.com>
> Tested-by:  Artem Lapkin <email2tema at gmail.com>
> Reviewed-by: Ramon Fried <rfried.dev at gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20211112/0619c565/attachment.sig>


More information about the U-Boot mailing list