[PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal

[Jagan Teki]

On Wed, Nov 3, 2021 at 4:11 PM liao jaime <jaimeliao.tw at gmail.com> wrote:
>
> Hi Jagan
>
>
> >
> > On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao <jaimeliao.tw at gmail.com> wrote:
> > >
> > > Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding
> > > Macronix flash in Octal DTR mode.
> > >
> > > Enable Octal DTR mode with 20 dummy cycles to allow running at the
> > > maximum supported frequency.
> > >  -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf
> > >
> > > Signed-off-by: JaimeLiao <jaimeliao.tw at gmail.com>
> > > ---
> > >  drivers/mtd/spi/Kconfig        |  7 +++
> > >  drivers/mtd/spi/spi-nor-core.c | 83 ++++++++++++++++++++++++++++++++++
> > >  include/linux/mtd/spi-nor.h    | 13 +++++-
> > >  3 files changed, 101 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
> > > index 1b2ef37e92..67599b32c9 100644
> > > --- a/drivers/mtd/spi/Kconfig
> > > +++ b/drivers/mtd/spi/Kconfig
> > > @@ -162,6 +162,13 @@ config SPI_FLASH_MACRONIX
> > >         help
> > >           Add support for various Macronix SPI flash chips (MX25Lxxx)
> > >
> > > +config SPI_FLASH_MACRONIX_OCTAL
> >
> > What if we use exiting SPI_FLASH_MACRONIX for it? does it increasing
> > size much? if not go for exiting macro.
> I want to seperate SPI_FLASH_MACRONIX and SPI_FLASH_MACRONIX_OCTAL for
> enabling Macronix octal support.
> Refer to your suggestions, checking SPI_FLASH_MACRONIX and other
> configuration which means octal enable is better.
> But I didn't found the existing configuration means "octal enable".
> It would be great if you can recommend the suitable configuration set
> for nor->fixups hooks macronix_octal_fixups.
> I will have v5 patchwork with the configuration checking.

My suggestion is go with existing Macronix config, if we keep adding
octal specific configs for each flash it will increase configs.

Jagan.