[PATCH RFC] cmd: fix net list command

Michael Walle michael at walle.cc
Mon Nov 15 16:15:31 CET 2021


Am 2021-11-15 16:12, schrieb Tom Rini:
> On Mon, Nov 15, 2021 at 03:52:51PM +0100, Michael Walle wrote:
>> Hi,
>> 
>> Am 2021-11-15 15:31, schrieb Wolfgang Denk:
>> > In message <c0282bc070180d74e055f82b5ecab5b0 at walle.cc> you wrote:
>> > >
>> > > And again you're masking the error and possible fixes by linux itself.
>> > > Seems like this isn't an argument.
>> >
>> > Respecting the explicit will of the user (i. e using what he
>> > configured in U-Boot and passed to the kernel) is not an error.  it
>> > is intended and documented behaviour.
>> 
>> What is the will of the user in this case? It is the will of the
>> developer to make the board more robust. That is, if there is
>> for whatever reason no valid ethernet address found, then there
>> will be one generated. That is the sole purpose of the config
>> option in question (or maybe I used it completely wrong). So from
>> a user perspective, this shouldn't even happen and I doubt he is
>> even aware that there will be a random one. (I saw Tom's mail and
>> I'm not talking about the USB adapters where this might be the
>> normal case.) I might come from a different perspective, but
>> users ususally don't look at the serial output. Instead they
>> look at the kernel log. And there will be not the slightest
>> error, because u-boot will happily fix the missing MAC address
>> with a random one.
> 
> So one thing I don't know is what's the situation on (I assume) the
> kontron boards?  I see both NXP reference platforms for layerscape and
> imx8 enabling NET_RANDOM_ETHADDR but I don't know what the expectation
> is for on-device MAC addresses, and I recall other threads talking
> about how complex the layerscape physical layout can get.  Thanks!

Kontron boards are fine, well at least if I disable the random mac
address config option, usually there is a serial console.

board/buffalo/lsxl.c needs it definetly (and was actually the first
user).

-michael


More information about the U-Boot mailing list