[PATCH 3/5] lmb: remove extern keyword in lmb.h

Ilias Apalodimas ilias.apalodimas at linaro.org
Mon Nov 15 16:44:27 CET 2021


On Sun, 14 Nov 2021 at 11:03, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> The extern keyword is not needed in include/lmb.h to declare functions.
> Remove it.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  include/lmb.h | 36 +++++++++++++++++-------------------
>  1 file changed, 17 insertions(+), 19 deletions(-)
>
> diff --git a/include/lmb.h b/include/lmb.h
> index 5efdf9d2e8..6182054f68 100644
> --- a/include/lmb.h
> +++ b/include/lmb.h
> @@ -74,13 +74,12 @@ struct lmb {
>  #endif
>  };
>
> -extern void lmb_init(struct lmb *lmb);
> -extern void lmb_init_and_reserve(struct lmb *lmb, struct bd_info *bd,
> -                                void *fdt_blob);
> -extern void lmb_init_and_reserve_range(struct lmb *lmb, phys_addr_t base,
> -                                      phys_size_t size, void *fdt_blob);
> -extern long lmb_add(struct lmb *lmb, phys_addr_t base, phys_size_t size);
> -extern long lmb_reserve(struct lmb *lmb, phys_addr_t base, phys_size_t size);
> +void lmb_init(struct lmb *lmb);
> +void lmb_init_and_reserve(struct lmb *lmb, struct bd_info *bd, void *fdt_blob);
> +void lmb_init_and_reserve_range(struct lmb *lmb, phys_addr_t base,
> +                               phys_size_t size, void *fdt_blob);
> +long lmb_add(struct lmb *lmb, phys_addr_t base, phys_size_t size);
> +long lmb_reserve(struct lmb *lmb, phys_addr_t base, phys_size_t size);
>  /**
>   * lmb_reserve_flags - Reserve one region with a specific flags bitfield.
>   *
> @@ -92,15 +91,14 @@ extern long lmb_reserve(struct lmb *lmb, phys_addr_t base, phys_size_t size);
>   */
>  long lmb_reserve_flags(struct lmb *lmb, phys_addr_t base,
>                        phys_size_t size, enum lmb_flags flags);
> -extern phys_addr_t lmb_alloc(struct lmb *lmb, phys_size_t size, ulong align);
> -extern phys_addr_t lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align,
> -                           phys_addr_t max_addr);
> -extern phys_addr_t __lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align,
> -                             phys_addr_t max_addr);
> -extern phys_addr_t lmb_alloc_addr(struct lmb *lmb, phys_addr_t base,
> -                                 phys_size_t size);
> -extern phys_size_t lmb_get_free_size(struct lmb *lmb, phys_addr_t addr);
> -extern int lmb_is_reserved(struct lmb *lmb, phys_addr_t addr);
> +phys_addr_t lmb_alloc(struct lmb *lmb, phys_size_t size, ulong align);
> +phys_addr_t lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align,
> +                          phys_addr_t max_addr);
> +phys_addr_t __lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align,
> +                            phys_addr_t max_addr);
> +phys_addr_t lmb_alloc_addr(struct lmb *lmb, phys_addr_t base, phys_size_t size);
> +phys_size_t lmb_get_free_size(struct lmb *lmb, phys_addr_t addr);
> +int lmb_is_reserved(struct lmb *lmb, phys_addr_t addr);
>  /**
>   * lmb_is_reserved_flags - test if tha address is in reserved region with a bitfield flag
>   *
> @@ -110,10 +108,10 @@ extern int lmb_is_reserved(struct lmb *lmb, phys_addr_t addr);
>   * Return:     if not reserved or reserved without the requested flag else 1
>   */
>  int lmb_is_reserved_flags(struct lmb *lmb, phys_addr_t addr, int flags);
> -extern long lmb_free(struct lmb *lmb, phys_addr_t base, phys_size_t size);
> +long lmb_free(struct lmb *lmb, phys_addr_t base, phys_size_t size);
>
> -extern void lmb_dump_all(struct lmb *lmb);
> -extern void lmb_dump_all_force(struct lmb *lmb);
> +void lmb_dump_all(struct lmb *lmb);
> +void lmb_dump_all_force(struct lmb *lmb);
>
>  static inline phys_size_t
>  lmb_size_bytes(struct lmb_region *type, unsigned long region_nr)
> --
> 2.32.0
>

Acked-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list